Skip to content

Commit

Permalink
Ensure get_requires* hook is called before prepare_metadata* (#3044)
Browse files Browse the repository at this point in the history
* Cache all hooks in Pep517VirtualEnvFrontend

This is useful when a hook is called multiple times (like
get_requires_for_build_wheel, which is called before
prepare_metadata_for_build_wheel and build_wheel).

* Extract build requires installation in Pep517VirtualEnvPackager

This method can then be re-used if we need to call
prepare_metadata_for_build_*.

* Ensure get_requires* is called before prepare_metadata*

To improve compatibility with PEP 517, the dependencies should be
installed before the prepare_metadata* hooks are called.

* Fix linting

* Add changelog entry

* Fix affected tests

* PR Feedback

Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>

* Improve bug fix message

Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>

* Fix tests

Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>

* More fixes

Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>

---------

Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
Co-authored-by: Bernát Gábor <bgabor8@bloomberg.net>
  • Loading branch information
abravalheri and gaborbernat authored Jun 20, 2023
1 parent 40411cf commit e66e346
Show file tree
Hide file tree
Showing 5 changed files with 35 additions and 18 deletions.
2 changes: 2 additions & 0 deletions docs/changelog/3043.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Ensure that ``get_requires_for_build_wheel`` is called before ``prepare_metadata_for_build_wheel``, and
``get_requires_for_build_editable`` is called before ``prepare_metadata_for_build_editable`` - by :user:`abravalheri`.
45 changes: 28 additions & 17 deletions src/tox/tox_env/python/virtual_env/package/pyproject.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import sys
from collections import defaultdict
from contextlib import contextmanager
from itertools import chain
from pathlib import Path
from threading import RLock
from typing import TYPE_CHECKING, Any, Dict, Generator, Iterator, NoReturn, Optional, Sequence, cast
Expand Down Expand Up @@ -97,6 +98,7 @@ def __init__(self, create_args: ToxEnvCreateArgs) -> None:
super().__init__(create_args)
self._frontend_: Pep517VirtualEnvFrontend | None = None
self.builds: defaultdict[str, list[EnvConfigSet]] = defaultdict(list)
self.call_require_hooks: set[str] = set()
self._distribution_meta: PathDistribution | None = None
self._package_dependencies: list[Requirement] | None = None
self._package_name: str | None = None
Expand Down Expand Up @@ -150,21 +152,23 @@ def meta_folder_if_populated(self) -> Path | None:
def register_run_env(self, run_env: RunToxEnv) -> Generator[tuple[str, str], PackageToxEnv, None]:
yield from super().register_run_env(run_env)
build_type = run_env.conf["package"]
self.call_require_hooks.add(build_type)
self.builds[build_type].append(run_env.conf)

def _setup_env(self) -> None:
super()._setup_env()
if "editable" in self.builds:
if "sdist" in self.call_require_hooks or "external" in self.call_require_hooks:
self._setup_build_requires("sdist")
if "wheel" in self.call_require_hooks:
self._setup_build_requires("wheel")
if "editable" in self.call_require_hooks:
if not self._frontend.optional_hooks["build_editable"]:
raise BuildEditableNotSupportedError
build_requires = self._frontend.get_requires_for_build_editable().requires
self._install(build_requires, PythonPackageToxEnv.__name__, "requires_for_build_editable")
if "wheel" in self.builds:
build_requires = self._frontend.get_requires_for_build_wheel().requires
self._install(build_requires, PythonPackageToxEnv.__name__, "requires_for_build_wheel")
if "sdist" in self.builds or "external" in self.builds:
build_requires = self._frontend.get_requires_for_build_sdist().requires
self._install(build_requires, PythonPackageToxEnv.__name__, "requires_for_build_sdist")
self._setup_build_requires("editable")

def _setup_build_requires(self, of_type: str) -> None:
requires = getattr(self._frontend, f"get_requires_for_build_{of_type}")().requires
self._install(requires, PythonPackageToxEnv.__name__, f"requires_for_build_{of_type}")

def _teardown(self) -> None:
executor = self._frontend.backend_executor
Expand All @@ -187,6 +191,7 @@ def perform_packaging(self, for_env: EnvConfigSet) -> list[Package]:
try:
deps = self._load_deps(for_env)
except BuildEditableNotSupportedError:
self.call_require_hooks.remove("editable")
targets = [e for e in self.builds.pop("editable") if e["package"] == "editable"]
names = ", ".join(sorted({t.env_name for t in targets if t.env_name}))

Expand All @@ -199,6 +204,7 @@ def perform_packaging(self, for_env: EnvConfigSet) -> list[Package]:
for env in targets:
env._defined["package"].value = "editable-legacy" # type: ignore[attr-defined] # noqa: SLF001
self.builds["editable-legacy"].append(env)
self._run_state["setup"] = False # force setup again as we need to provision wheel to get dependencies
deps = self._load_deps(for_env)
of_type: str = for_env["package"]
if of_type == "editable-legacy":
Expand Down Expand Up @@ -309,12 +315,13 @@ def get_package_name(self, for_env: EnvConfigSet) -> str:
def _ensure_meta_present(self, for_env: EnvConfigSet) -> None:
if self._distribution_meta is not None: # pragma: no branch
return # pragma: no cover
# even if we don't build a wheel we need the requirements for it should we want to build its metadata
target = "editable" if for_env["package"] == "editable" else "wheel"
self.call_require_hooks.add(target)

self.setup()
end = self._frontend
if for_env["package"] == "editable":
dist_info = end.prepare_metadata_for_build_editable(self.meta_folder, self._wheel_config_settings).metadata
else:
dist_info = end.prepare_metadata_for_build_wheel(self.meta_folder, self._wheel_config_settings).metadata
hook = getattr(self._frontend, f"prepare_metadata_for_build_{target}")
dist_info = hook(self.meta_folder, self._wheel_config_settings).metadata
self._distribution_meta = Distribution.at(str(dist_info))

@property
Expand All @@ -332,12 +339,16 @@ def __init__(self, root: Path, env: Pep517VirtualEnvPackager) -> None:
self._backend_executor_: LocalSubProcessPep517Executor | None = None
into: dict[str, Any] = {}

for build_type in ("editable", "sdist", "wheel"): # wrap build methods in a cache wrapper
for hook in chain(
(f"get_requires_for_build_{build_type}" for build_type in ["editable", "wheel", "sdist"]),
(f"prepare_metadata_for_build_{build_type}" for build_type in ["editable", "wheel"]),
(f"build_{build_type}" for build_type in ["editable", "wheel", "sdist"]),
): # wrap build methods in a cache wrapper

def key(*args: Any, bound_return: str = build_type, **kwargs: Any) -> str: # noqa: ARG001
def key(*args: Any, bound_return: str = hook, **kwargs: Any) -> str: # noqa: ARG001
return bound_return

setattr(self, f"build_{build_type}", cached(into, key=key)(getattr(self, f"build_{build_type}")))
setattr(self, hook, cached(into, key=key)(getattr(self, hook)))

@property
def backend_cmd(self) -> Sequence[str]:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ def test_tox_install_pkg_sdist(tox_project: ToxProjectCreator, pkg_with_extras_p
(".pkg_external_sdist_meta", "install_requires", ["setuptools", "wheel"]),
(".pkg_external_sdist_meta", "_optional_hooks", []),
(".pkg_external_sdist_meta", "get_requires_for_build_sdist", []),
(".pkg_external_sdist_meta", "get_requires_for_build_wheel", []), # required before prepare_metadata*
(".pkg_external_sdist_meta", "install_requires_for_build_wheel", ["wheel"]),
(".pkg_external_sdist_meta", "prepare_metadata_for_build_wheel", []),
("py", "install_package_deps", deps),
("py", "install_package", ["--force-reinstall", "--no-deps", str(pkg_with_extras_project_sdist)]),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ def test_pyproject_deps_static_with_dynamic( # noqa: PLR0913
expected_calls = [
(".pkg", "_optional_hooks"),
(".pkg", "get_requires_for_build_sdist"),
(".pkg", "get_requires_for_build_wheel"),
(".pkg", "build_wheel"),
(".pkg", "build_sdist"),
("py", "install_package_deps"),
Expand All @@ -239,10 +240,10 @@ def test_pyproject_no_build_editable_fallback(tox_project: ToxProjectCreator, de

expected_calls = [
(".pkg", "_optional_hooks"),
(".pkg", "get_requires_for_build_wheel"),
(".pkg", "build_wheel"),
(".pkg", "get_requires_for_build_sdist"),
("a", "install_package"),
(".pkg", "get_requires_for_build_sdist"),
("b", "install_package"),
(".pkg", "_exit"),
]
Expand Down
1 change: 1 addition & 0 deletions tests/tox_env/test_tox_env_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ def test_package_only(
expected_calls = [
(".pkg", "_optional_hooks"),
(".pkg", "get_requires_for_build_sdist"),
(".pkg", "get_requires_for_build_wheel"),
(".pkg", "build_wheel"),
(".pkg", "build_sdist"),
(".pkg", "_exit"),
Expand Down

0 comments on commit e66e346

Please sign in to comment.