-
-
Notifications
You must be signed in to change notification settings - Fork 523
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Cache all hooks in Pep517VirtualEnvFrontend This is useful when a hook is called multiple times (like get_requires_for_build_wheel, which is called before prepare_metadata_for_build_wheel and build_wheel). * Extract build requires installation in Pep517VirtualEnvPackager This method can then be re-used if we need to call prepare_metadata_for_build_*. * Ensure get_requires* is called before prepare_metadata* To improve compatibility with PEP 517, the dependencies should be installed before the prepare_metadata* hooks are called. * Fix linting * Add changelog entry * Fix affected tests * PR Feedback Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net> * Improve bug fix message Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net> * Fix tests Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net> * More fixes Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net> --------- Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net> Co-authored-by: Bernát Gábor <bgabor8@bloomberg.net>
- Loading branch information
1 parent
40411cf
commit e66e346
Showing
5 changed files
with
35 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Ensure that ``get_requires_for_build_wheel`` is called before ``prepare_metadata_for_build_wheel``, and | ||
``get_requires_for_build_editable`` is called before ``prepare_metadata_for_build_editable`` - by :user:`abravalheri`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters