Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems with path relativization in commands section #1463

Closed
i386x opened this issue Nov 21, 2019 · 5 comments
Closed

Problems with path relativization in commands section #1463

i386x opened this issue Nov 21, 2019 · 5 comments
Labels
bug:normal affects many people or has quite an impact help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted.
Milestone
4.0

Comments

@i386x
Copy link

i386x commented Nov 21, 2019 •
edited
Loading

Hello,

the shortening absolute path to relative ones may break some use cases when for example {envpython} is passed to shell script. I don't know whether this should be considered as a bug or not but at least it should be mentioned here.
@i386x i386x added the bug:normal affects many people or has quite an impact label Nov 21, 2019
@i386x i386x mentioned this issue Nov 21, 2019
Closed
i386x added a commit to linux-system-roles/network that referenced this issue Nov 21, 2019
@i386x
Sanitize script arguments
d2d9eaf 
See tox-dev/tox#1463 for details.
i386x added a commit to i386x/template that referenced this issue Nov 21, 2019
@i386x
Sanitize script arguments
922b3e8 
See tox-dev/tox#1463 for details.
i386x added a commit to linux-system-roles/storage that referenced this issue Nov 22, 2019
@i386x
Sanitize script arguments
100215a 
See tox-dev/tox#1463 for details.
@pcahyna
Copy link

pcahyna commented Nov 25, 2019

IIUC the issue is, when there is a complex command containing some cd ... &&, replacing absolute paths by relative everywhere in the command does no longer work as expected (after the cd).

@i386x i386x changed the title Please document path relativization in commands Problems with path relativization in commands section Nov 25, 2019
@gaborbernat gaborbernat added the help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted. label Nov 26, 2019
tyll pushed a commit to linux-system-roles/network that referenced this issue Nov 27, 2019
@i386x @tyll
Sanitize script arguments
ede025f 
See tox-dev/tox#1463 for details.
i386x added a commit to linux-system-roles/storage that referenced this issue Mar 30, 2020
@i386x
Sanitize script arguments
9f1bbbb 
See tox-dev/tox#1463 for details.
@gaborbernat
Copy link
Member

Feel free to open a PR against master and fix it. My available efforts at the moment are aimed at fixing this as part of #1394, but that probably will take a while (ETA September).

@jayvdb jayvdb mentioned this issue Oct 20, 2020
Closed
@jayvdb
Copy link

jayvdb commented Oct 20, 2020

@i386x does #1339 explain your problem?

If it is different, perhaps you could provide a sample tox.ini to help diagnose the problem.

@i386x
Copy link
Author

i386x commented Oct 20, 2020

Yes, #1339 is the same problem.

@gaborbernat
Copy link
Member

This is now fixed on the rewrite branch.

@gaborbernat gaborbernat added this to the 4.0 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:normal affects many people or has quite an impact help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted.
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
4 participants
@jayvdb @gaborbernat @i386x @pcahyna