Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1227 fix crash when proposed base python has no version data #1229

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Mar 29, 2019

Resolves #1227.

@todo
Copy link

todo bot commented Mar 29, 2019

(stephenfin): Raise an exception here in tox 4.0

# TODO(stephenfin): Raise an exception here in tox 4.0
warnings.warn(
"conflicting basepython version (set {}, should be {}) for env '{}';"
"resolve conflict or set ignore_basepython_conflict".format(
proposed_version, implied_version, testenv_config.envname
)


This comment was generated by todo based on a TODO comment in 407121b in #1229. cc @gaborbernat.

Copy link
Contributor

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit 47476e1 into tox-dev:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants