Fix usedevelop without setup.py #2198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoineD
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
gaborbernat
requested changes
Sep 2, 2021
gaborbernat
reviewed
Sep 2, 2021
|
What do you mean by old and new world? |
|
It should work with any setuptools/pip version the user might use. |
|
It seems to me that it does not worth the effort then, as compared to creating an almost empty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2197
I was able to check the fix on an external project but unfortunately the new test does not work when the
cmdfixture is called the second time (error at teardown).Please let me know how to fix this test or feel free to change it.