Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Python 3.7 #866

Merged
merged 1 commit into from
Jul 3, 2018
Merged

Adopt Python 3.7 #866

merged 1 commit into from
Jul 3, 2018

Conversation

gaborbernat
Copy link
Member

  • add Python 3.8 dev tests as failure allowed
  • Python 3.7 tests are no longer allowed to fail

@codecov
Copy link

codecov bot commented Jul 2, 2018

Codecov Report

Merging #866 into master will increase coverage by <1%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #866    +/-   ##
======================================
+ Coverage      92%    92%   +<1%     
======================================
  Files          12     12            
  Lines        2331   2331            
  Branches      408    408            
======================================
+ Hits         2155   2156     +1     
  Misses        110    110            
+ Partials       66     65     -1

@asottile
Copy link
Contributor

asottile commented Jul 2, 2018

this is likely blocked on

  • pyyaml making a release
  • appveyor having python3.7 installed

@gaborbernat gaborbernat force-pushed the py3.7 branch 3 times, most recently from b8368d3 to 27322bd Compare July 3, 2018 08:00
- add Python 3.8 dev tests as failure allowed
- Python 3.7 tests are no longer allowed to fail
@gaborbernat
Copy link
Member Author

I'll move fix-lint to Python 3.6 (we'll update it to 3.7 after yaml/pyyaml#193). And for now, not run Windows test for Python 3.7 (we'll add it in a new PR once appveyor/ci#2475 is released).

With these three we can go ahead. Also defined stages to not run tests if the linting fails.

@gaborbernat gaborbernat merged commit f2e120c into tox-dev:master Jul 3, 2018
@gaborbernat gaborbernat deleted the py3.7 branch July 3, 2018 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants