Skip to content

Remove Tracker workaround #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Remove Tracker workaround #124

merged 1 commit into from
Feb 12, 2025

Conversation

devmotion
Copy link
Collaborator

Fixes #20 since the referenced issue is fixed (and Tracker is somewhat retired anyway and not tested anymore).

@tpapp do you remember why you wanted to use copy(x) instead of indexing into the provided vector?

@tpapp
Copy link
Owner

tpapp commented Feb 12, 2025

Yes. By default none of the as(Array, ...) transform share structure, so this should copy.

There is as(view, ...) for the special case.

@devmotion
Copy link
Collaborator Author

none of the as(Array, ...) transform share structure

I was wondering, isn't that already achieved by taking the subset x[index:...]? This already creates a separate array.

@tpapp
Copy link
Owner

tpapp commented Feb 12, 2025

Good point. Then I have no idea why I had copy.

Thanks for all the improvements. Should I tag a release or do you want to make more changes?

Copy link
Owner

@tpapp tpapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@tpapp tpapp merged commit a8cab22 into tpapp:master Feb 12, 2025
5 checks passed
@devmotion devmotion deleted the dw/todo branch February 12, 2025 10:01
@devmotion
Copy link
Collaborator Author

Thanks for all the improvements. Should I tag a release or do you want to make more changes?

I don't have any plans for additional PRs right now, I just happened to do some TransformVariables-related work this morning 😄 So it's probably time for a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove workaround for copy(::TrackedArray)
2 participants