Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct packaging issues #56

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

henryiii
Copy link
Contributor

Should fix #55.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@lgray lgray mentioned this pull request Aug 27, 2024
MANIFEST.in Show resolved Hide resolved
@tpgillam
Copy link
Owner

Thanks for looking at this!

I was initially surprised as I had hoped that the cibuildwheel option to test the wheels that we are using would have caught this, but it did not. We’ll need to figure out how to add a check that would have caught this.

@henryiii
Copy link
Contributor Author

The problem is that you aren't using src structure. This is a good idea for all code, but an especially good idea for compiled code. See https://learn.scientific-python.org/development/guides/packaging-simple/#package-structure. So you are often picking up the local "mt2" directory and not noticing that it's not in the wheel.

setup.py Outdated Show resolved Hide resolved
@tpgillam
Copy link
Owner

The problem is that you aren't using src structure.

I can certainly believe that might be a fix.

But why must it be the only fix? Another option would be for the tests to be run in an isolated environment in which we install the generated wheel explicitly. This seems less sensitive to future changes.

@tpgillam tpgillam self-requested a review August 28, 2024 17:10
@tpgillam tpgillam merged commit cf21dd9 into tpgillam:master Aug 28, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wheels are not correctly built
2 participants