Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: put python source in src/mt2 to avoid import confusion #58

Merged
merged 10 commits into from
Aug 29, 2024

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Aug 28, 2024

Fixes more little issues that came up in #55.

This makes it so cibuildwheel automatically checks that the wheel is correctly formed and installs correctly.

@lgray
Copy link
Contributor Author

lgray commented Aug 28, 2024

Yep, there we go.
@tpgillam good to go now with a small organizational change.

@lgray
Copy link
Contributor Author

lgray commented Aug 28, 2024

@henryiii what's the correct invocation to pick up the mt2 package in this case? If I try include = ["src/mt2*"] then it fails when running tests from actions inside the uv sync venv.

I can reproduce this on my laptop but it's not exactly clear what's going wrong.

@lgray
Copy link
Contributor Author

lgray commented Aug 28, 2024

Ah, nevermind. Read the manual. :-)

@lgray
Copy link
Contributor Author

lgray commented Aug 29, 2024

@tpgillam I'm happy to back out the second commit I've added. It makes the extension _mt2 a sub-package of mt2, which is a common practice. It has an added side effect that the built shared object libraries stay within the package subdirectory wherever mt2 is installed, which is pleasantly clean.

@tpgillam tpgillam self-requested a review August 29, 2024 08:21
@tpgillam
Copy link
Owner

Thanks @lgray ! Looks good - can you have a look at lgray#2 please? It's a "review" into this branch with a few other teaks, and bumping the version to 1.2.2 .

@tpgillam tpgillam enabled auto-merge (squash) August 29, 2024 13:17
@tpgillam tpgillam merged commit 46dc153 into tpgillam:master Aug 29, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants