fapi: fix usage of policy_nv. #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it was not possible to define a policy nv with a TPM nv index. The callback to get the public nv data related to the policy was extended to get public nv data from the TPM in this case. Addresses tpm2-software#2383. Signed-off-by: Juergen Repp <juergen_repp@web.de>
A nv policy with the nv index 0x1800000 was added, and the integration test for policy nv was modified to test also this policy. Signed-off-by: Juergen Repp <juergen_repp@web.de>
Codecov Report
@@ Coverage Diff @@
## master #2384 +/- ##
==========================================
- Coverage 83.64% 83.60% -0.04%
==========================================
Files 351 351
Lines 37877 37895 +18
==========================================
+ Hits 31681 31682 +1
- Misses 6196 6213 +17
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
williamcroberts
approved these changes
Jul 8, 2022
| be used to get the public from the keystore if no nv_index is | ||
| passed. | ||
| * @param[in] nv_index The index of the NV object. The index will be used to | ||
| * get the public data if nv_index > 0. |
There was a problem hiding this comment.
ahh ok if nv_index is 0 look at path..., is the inverse thru if not path look at index?
There was a problem hiding this comment.
ahh ok if nv_index is 0 look at path..., is the inverse thru if not path look at index?
yes. It's ensured by ifapi_json_TPMS_POLICYNV_deserialize that either nv_index or path is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback to get the public nv data related to the policy was extended
to get public nv data from the TPM in this case.
Addresses Questions policy JSON encoding and callbacks with tss2-policy #2383
Signed-off-by: Juergen Repp juergen_repp@web.de