tcti-spi-helper: uint32_t is conversion to a void* buffer fails on big endian #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g endian We need to convert it back to the correct endianess. tpm2-software#2531 Signed-off-by: Lukas Märdian <slyon@ubuntu.com>
wxleong
suggested changes
Oct 19, 2023
There was a problem hiding this comment.
- Please avoid using
le32toh()directly; instead, useLE_TO_HOST_32()from https://github.com/tpm2-software/tpm2-tss/blob/master/src/util/tss2_endian.h. - The
spi_tpm_helper_write_sts_reg()function also requires endianness correction. did_vidcheck requires correction too.
You may refer to:
https://github.com/tpm2-software/tpm2-tss/blob/master/src/tss2-tcti/tcti-i2c-helper.c#L349
https://github.com/tpm2-software/tpm2-tss/blob/master/src/tss2-tcti/tcti-i2c-helper.c#L356
https://github.com/tpm2-software/tpm2-tss/blob/master/src/tss2-tcti/tcti-i2c-helper.c#L785
JuergenReppSIT
added a commit
to JuergenReppSIT/tpm2-tss
that referenced
this pull request
Dec 4, 2023
Based on tpm2-software#2686 In the function spi_tpm_helper_read_sts_reg the result is converted back to the correct endianess. Addresses tpm2-software#2531 Co-authored-by: Lukas Märdian <slyon@ubuntu.com> Signed-off-by: Juergen Repp <juergen_repp@web.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to convert it back to the correct endianess.
Partly fixes: #2531