Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcti-helper: Properly handle state transition from init to ready #2689

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

wxleong
Copy link
Member

@wxleong wxleong commented Sep 8, 2023

If the TPM does not automatically transition from TPM_Init -> idle -> ready after waiting for TIMEOUT_B, manually initiate the transition by writing 1 to TPM_STS_x.commandReady.

resolves #2671

If the TPM does not automatically transition from init -> idle -> ready, manually trigger the transition by writing 1 to commandReady.

Signed-off-by: wenxin.leong <wenxin.leong@infineon.com>
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #2689 (41f58ba) into master (b7bad34) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #2689      +/-   ##
==========================================
- Coverage   82.57%   82.55%   -0.02%     
==========================================
  Files         368      368              
  Lines       42980    42986       +6     
==========================================
- Hits        35491    35489       -2     
- Misses       7489     7497       +8     
Files Changed Coverage Δ
src/tss2-tcti/tcti-spi-helper.c 46.08% <40.00%> (-0.12%) ⬇️
src/tss2-tcti/tcti-i2c-helper.c 82.84% <60.00%> (-0.44%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

@AndreasFuchsTPM AndreasFuchsTPM merged commit 5412bca into tpm2-software:master Sep 14, 2023
@wxleong wxleong deleted the fix-tcti-helper branch July 3, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tcti-spi-helper does not tell the TPM to become ready
2 participants