FAPI: Fix usage of endorsement handle #2711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuergenReppSIT
force-pushed
the
fapi-fix-usage-of-endorsement-handle
branch
2 times, most recently
from
e9f1178 to
65f82da
Compare
In several cases the wrong handle TPM2_RH_EK was used instead of TPM2_RH_ENDORSEMENT. This caused a wrong recreation of keys (except the EK) under the endorsement hierarchy. Now the correct hierarchy handle is used and a check whether the recreated public key of the recreated primary corresponds to the keystore. Addresses: tpm2-software#2709 Signed-off-by: Juergen Repp <juergen_repp@web.de>
JuergenReppSIT
force-pushed
the
fapi-fix-usage-of-endorsement-handle
branch
from
65f82da to
fb191f4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2711 +/- ##
==========================================
- Coverage 82.60% 82.58% -0.02%
==========================================
Files 368 368
Lines 43001 43006 +5
==========================================
- Hits 35519 35517 -2
- Misses 7482 7489 +7 ☔ View full report in Codecov by Sentry. |
| context->ek_persistent = true; | ||
| } else { | ||
| } else if (strcmp("/SRK", | ||
| &pkey_object->rel_path[strlen(pkey_object->rel_path)-4]) == 0) { | ||
| context->srk_persistent = true; | ||
| } |
There was a problem hiding this comment.
Is the no else possible after these two cases ?
There was a problem hiding this comment.
Yes it's possible. ek_persistentand srk_persistentare only used in the provisioning cleanup for the EK and SRK and in the cleanup for sessions where the SRK is used as TPM key.
AndreasFuchsTPM
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several cases the wrong handle TPM2_RH_EK was used instead of TPM2_RH_ENDORSEMENT.
This caused a wrong recreation of keys (except the EK) under the endorsement hierarchy.
Addresses: #2709
Signed-off-by: Juergen Repp juergen_repp@web.de