FAPI: Fix usage of endorsement handle 3.2.x #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In several cases the wrong handle TPM2_RH_EK was used instead of TPM2_RH_ENDORSEMENT. This caused a wrong recreation of keys (except the EK) under the endorsement hierarchy. Now the correct hierarchy handle is used and a check whether the recreated public key of the recreated primary corresponds to the keystore. Signed-off-by: Juergen Repp <juergen_repp@web.de>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 3.2.x #2712 +/- ##
=======================================
Coverage 83.67% 83.67%
=======================================
Files 349 349
Lines 38683 38685 +2
=======================================
+ Hits 32369 32371 +2
Misses 6314 6314 ☔ View full report in Codecov by Sentry. |
AndreasFuchsTPM
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several cases the wrong handle TPM2_RH_EK was used instead of TPM2_RH_ENDORSEMENT.
This caused a wrong recreation of keys (except the EK) under the endorsement hierarchy.
Now the correct hierarchy handle is used and a check whether the recreated public key of the recreated primary corresponds to the keystore.
Signed-off-by: Juergen Repp juergen_repp@web.de