FAPI: fix problems detected by scanner. #2906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JuergenReppSIT
commented
Oct 20, 2024
•
JuergenReppSIT
commented
- Fix missing check of scanf result.
- Fix storing of local variable stored in non-local memory.
- MU: Remove unneeded cast in TPM2B_UNMARSHAL.
JuergenReppSIT
force-pushed
the
fapi-fix-scanner-errors
branch
11 times, most recently
from
81dab14 to
9d7b3b5
Compare
JuergenReppSIT
force-pushed
the
fapi-fix-scanner-errors
branch
from
9d7b3b5 to
78abea0
Compare
JuergenReppSIT
force-pushed
the
fapi-fix-scanner-errors
branch
from
78abea0 to
8ba41f7
Compare
In several cases the return value of scanf was not checked. Thus afterwards acces to variables not initialized was possible. Signed-off-by: Juergen Repp <juergen_repp@web.de>
The corresponding local array is now created with malloc and freed after the execution of Fapi_WriteAuthorizeNv_Finish. Signed-off-by: Juergen Repp <juergen_repp@web.de>
JuergenReppSIT
force-pushed
the
fapi-fix-scanner-errors
branch
from
8ba41f7 to
41b94ad
Compare
An uneeded cast was removed, because the name of the used buffer was passed to TPM2B_UNMARSHAL and could be used. Signed-off-by: Juergen Repp <juergen_repp@web.de>
AndreasFuchsTPM
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.