Enable Unix domain socket support #418
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch allows users to connect to nREPL servers running on Unix domain sockets by modifying :FireplaceConnect to let users provide a connection string pointing to a socket file on the filesystem. This is accomplished by modifying the setup code to identify such connection strings and skip the URL building process and updating the Python script to look for non-URL strings and attempt to connect to them as socket type `AF_UNIX`. For now, socket connections are assumed to be using the `nrepl` scheme, and the current directory (or `b:java_root`) is used to populate the "Scope connection to: " prompt. Also removes the vestigial second argument to the Python script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #417.
The socket support can be tested by starting a repl with a command like
clj -Srepro -Sdeps '{:deps {nrepl/nrepl {:mvn/version "1.1.1"}}}' -M -m nrepl.cmdline --socket /tmp/my_socketthen connecting to it in Vim with:FireplaceConnect /tmp/my_socket.This patch allows users to connect to nREPL servers running on Unix domain sockets by modifying :FireplaceConnect to let users provide a connection string pointing to a socket file on the filesystem.
This is accomplished by modifying the setup code to identify such connection strings and skip the URL building process and updating the Python script to look for non-URL strings and attempt to connect to them as socket type
AF_UNIX.For now, socket connections are assumed to be using the
nreplscheme, and the current directory (orb:java_root) is used to populate the "Scope connection to: " prompt.Also removes the vestigial second argument to the Python script.