Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add highlighting for trailing whitespace #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add highlighting for trailing whitespace #52

wants to merge 1 commit into from

Conversation

FST777
Copy link

@FST777 FST777 commented Oct 15, 2013

Double spaces are used in markdown to trigger a hard linebreak

Double spaces are used in markdown to trigger a hard linebreak
@tpope
Copy link
Owner

tpope commented Jul 11, 2014

This is a reasonable goal, but I don't think hard coding a color is a good practice, and I'm not sure what to link it to.

@FST777
Copy link
Author

FST777 commented Jul 11, 2014

Neither was I, tbh...

I currently don't use markdown anymore, so I uninstalled this plugin. Let
me know if you want me to take another look.

Groet,

Fi-Ji
On 11 Jul 2014 19:46, "Tim Pope" notifications@github.com wrote:

This is a reasonable goal, but I don't think hard coding a color is a good
practice, and I'm not sure what to link it to.


Reply to this email directly or view it on GitHub
#52 (comment).

@STOWouters
Copy link

It's a good thing to highlight trailing whitespace, perhaps you can link it to an 'error' color? You know, that red color when typing invalid HTML syntax, something like this one:

vim

Not sure if using such 'error' color is a good thing, but I can imagine that you don't want hard linebreaks at all sometimes, so I consider it's good enough to use an 'error' highlight.

@alerque
Copy link

alerque commented Mar 8, 2016

I agree with @Stijn-Flipper that linking this to the error style being the best way forward. Since the OP has removed their fork I've taken the liberty of rebasing this and making that adjustment in #97. This PR is now obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants