Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable quote style for Rextract's render 'foo' #343

Closed
henrik opened this issue Aug 29, 2014 · 5 comments
Closed

Configurable quote style for Rextract's render 'foo' #343

henrik opened this issue Aug 29, 2014 · 5 comments

Comments

@henrik
Copy link
Contributor

henrik commented Aug 29, 2014

Would you accept a patch for (or add yourself) a way to configure the quote style used for Rextract's render 'foo' string? Our team has a double-quote convention so being able to configure that would remove a tiny annoyance.

@tpope tpope closed this as completed in 41380b1 May 8, 2015
@tpope
Copy link
Owner

tpope commented May 8, 2015

Let's just change it and see who complains.

@henrik
Copy link
Contributor Author

henrik commented May 9, 2015

👍 Thanks for that!

@jeromedalbert
Copy link

jeromedalbert commented Jun 22, 2016

Let's just change it and see who complains.

I do. 😁 Our team has a single-quote convention that is opposite to @henrik's. I guess the best solution is to have a vim-rails global option?

@henrik
Copy link
Contributor Author

henrik commented Jun 22, 2016

@jeromedalbert Clearly the best solution is for your team to see the light ;D Kidding.

henrik added a commit to henrik/vim-rails that referenced this issue Jun 22, 2016
The style was changed in tpope#343.

If tpope#458 happens, we can change this again.
tpope pushed a commit that referenced this issue Jun 22, 2016
The style was changed in #343.

If #458 happens, we can change this again.
@jeromedalbert
Copy link

@henrik made a quick PR, for what it's worth!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants