Fix repeat after undo #79
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If someone could confirm whether it fixes the issue and/or it creates a new issue, that would help. |
|
Thank you! I also attempted to fix this way back in 2018 (which is still waiting approval) but your approach sounds better. I'll start using your fork to do some extra QA on it until this gets approved Hopefully this PR gets looked at sooner than mine. Would love for this to get merged. |
|
I should also mention that this does fix the issue for me as well |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the issue #63. It delays the ticks synchronization until the next
TextChanged, which is necessary becausefeedkeys()does not execute the undo command immediately. See this comment for more context.