Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Fix - Final Batch Size if Total Samples to use in FID Calculation is a multiple of Batch Size #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tempoxylophone
Copy link

Thank you so much for open sourcing this work! I think I may have found a very, very slight issue.

When using the --eval-total-size argument, the final batch in the evaluator will be 0 if the value passed to --eval-total-size is a multiple of the batch size, i.e. self.eval_total_size % self.eval_batch_size = 0.

python train.py --eval --eval-total-size 512

This will cause a ValueError later in the FID calculation since we compute the mean of an empty array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant