Skip to content

Commit

Permalink
fix: Remove unnecessary dependency on mysqlclient (feast-dev#3925)
Browse files Browse the repository at this point in the history
  • Loading branch information
tokoko authored and tqtensor committed Mar 11, 2024
1 parent 04a04b8 commit 5fa65e9
Show file tree
Hide file tree
Showing 7 changed files with 2 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ RUN apt update && \
apt install -y \
jq \
python3-dev \
default-libmysqlclient-dev \
build-essential

RUN pip install pip --upgrade
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ RUN apt update && \
apt install -y \
jq \
python3-dev \
default-libmysqlclient-dev \
build-essential

RUN pip install pip --upgrade
Expand Down
2 changes: 0 additions & 2 deletions sdk/python/requirements/py3.10-ci-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -472,8 +472,6 @@ mypy-extensions==1.0.0
# mypy
mypy-protobuf==3.1.0
# via feast (setup.py)
mysqlclient==2.2.0
# via feast (setup.py)
nbclient==0.9.0
# via nbconvert
nbconvert==7.11.0
Expand Down
2 changes: 0 additions & 2 deletions sdk/python/requirements/py3.8-ci-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -488,8 +488,6 @@ mypy-extensions==1.0.0
# mypy
mypy-protobuf==3.1.0
# via feast (setup.py)
mysqlclient==2.2.0
# via feast (setup.py)
nbclient==0.9.0
# via nbconvert
nbconvert==7.11.0
Expand Down
2 changes: 0 additions & 2 deletions sdk/python/requirements/py3.9-ci-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -479,8 +479,6 @@ mypy-extensions==1.0.0
# mypy
mypy-protobuf==3.1.0
# via feast (setup.py)
mysqlclient==2.2.0
# via feast (setup.py)
nbclient==0.9.0
# via nbconvert
nbconvert==7.11.0
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/unit/test_sql_registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def mysql_registry():

registry_config = RegistryConfig(
registry_type="sql",
path=f"mysql+mysqldb://{POSTGRES_USER}:{POSTGRES_PASSWORD}@127.0.0.1:{container_port}/{POSTGRES_DB}",
path=f"mysql+pymysql://{POSTGRES_USER}:{POSTGRES_PASSWORD}@127.0.0.1:{container_port}/{POSTGRES_DB}",
)

yield SqlRegistry(registry_config, "project", None)
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
"psycopg2-binary>=2.8.3,<3",
]

MYSQL_REQUIRED = ["mysqlclient", "pymysql", "types-PyMySQL"]
MYSQL_REQUIRED = ["pymysql", "types-PyMySQL"]

HBASE_REQUIRED = [
"happybase>=1.2.0,<3",
Expand Down

0 comments on commit 5fa65e9

Please sign in to comment.