Initial marketplace UI implementation #280
Conversation
|
Bug: After listing the first item on marketplace, and trying to list a 2nd, got "Listing succesful": (This has not been listed yet) |
|
Bug: Listing 2 items in the marketplace, does not display correctly:
|
|
Bug: Layout - Screen width < ~1040 doesn't work fit:
|
|
Bug: Cancel sell -> Reject Transaction, causes the modal to get stuck:
|
Good bug find but unrelated to the marketplace page. Opened as issue #285 |
Unrelated to this PR. Opened as issue #286 |
| my={4} | ||
| onClick={e => { | ||
| e.preventDefault(); | ||
| setLocation(`/collection/${props.address}/token/${props.id}`, { replace: true }); |
There was a problem hiding this comment.
This should be replace: false, or else the back button will not go back to marketplace.
| network: string; | ||
| } | ||
|
|
||
| export default function FeaturedToken(props: FeaturedTokenProps) { |
There was a problem hiding this comment.
This breaks with small width:
There was a problem hiding this comment.
This breaks with small width:
Can you tell me what browser version and OS you are using? It is coded that the image and content stack on top of each other in small screens. Possible Chakra-ui bug here.
| <video | ||
| loop | ||
| onClick={e => e.preventDefault()} | ||
| onMouseEnter={e => e.currentTarget.play()} |
There was a problem hiding this comment.
Nice, I like the play on hover
There was a problem hiding this comment.
hah some people don't and want the video to play all the time. I tend to prefer the play on hover as well but I might be outvoted here.
|
Placing a token for sell causes 2 transactions to be approved. I don't know if it is possible to make this one transaction. |
It is, though unrelated to this specific PR, I did mean to fix it in here. Thanks for reminding me. I will open a new issue for tracking and fix in this PR. |
Initial marketplace UI implementation. closes #210