Fix failing Travis build due to issues 39-45 #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poetry is now installed using official `get-poetry.py` script using --preview flag. Script is downloaded to /tmp directory and poetry environment is sourced into the Travis' shell.
This was referenced Sep 26, 2020
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
===========================================
- Coverage 100.00% 99.60% -0.40%
===========================================
Files 6 7 +1
Lines 597 760 +163
Branches 116 150 +34
===========================================
+ Hits 597 757 +160
- Misses 0 1 +1
- Partials 0 2 +2
Continue to review full report at Codecov.
|
|
I don't have that much experience with using codecov. Could somebody please help with fixing this 0.4% not covered due to the fix added for #45? |
|
Thank you @tr11 for merging the PR and adding all the required annotations for codecov to make it pass. Such a swift review and consideration from your side! P.S. |
|
You're very welcome. Always looking for people to contribute to the project 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several issues that prevented successful Travis build.
Affected issues
Fixes #39
Fixes #41
Fixes #43
Fixes #45
Build results
Link to successful Travis build: https://travis-ci.org/github/vduseev/python-configuration/builds/730480955
Thoughts
Maybe we can add couple new settings to existing Travis configuration?