Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added translation key for keybind category (fix issue #172) #175

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

Thijzert123
Copy link
Contributor

Use a translation key for the title of the keybind category. This allows resource packs to change the title without changing the mod (#172).

Copy link

what-the-diff bot commented Oct 28, 2024

PR Summary

  • Modification of Key Binding String
    The key binding string used to toggle the 'Entity Culling' feature within the application has been updated. Previously, this string was identified as "key.entityculling.toggle", however, it has now been changed to "text.entityculling.title". This change is set to enhance the user's ability to identify and use this function.

Copy link

sonarcloud bot commented Oct 28, 2024

@tr7zw
Copy link
Owner

tr7zw commented Oct 28, 2024

As noted on the other issue, "EntityCulling" IS the translation key technically. Also not sure why anyone would try to translate a name, so I see this more as a thing of correctness, not useful to anyone?

@Thijzert123
Copy link
Contributor Author

It could be useful for someone that wants to give their own twist to Minecraft by changing all the text, or if you want to change the name to something more understandable for people that don't speak English at all. It makes more sense if it looks like most translation keys, instead of an unpredictable name such as "EntityCulling".

@tr7zw tr7zw merged commit 0084c5c into tr7zw:main Oct 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants