Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.20.5 #140

Merged
merged 8 commits into from
Apr 29, 2024
Merged

Update to 1.20.5 #140

merged 8 commits into from
Apr 29, 2024

Conversation

katietheqt-old
Copy link
Contributor

@katietheqt-old katietheqt-old commented Apr 29, 2024

This PR updates Exordium to 1.20.5

As part of this, I removed gradle-compose - it was unused anyway (Forge support was officially removed in 1.20.4) and the mod template is not currently up to date (nor could it be, as architectury loom has not updated). Also closes #113, closes #116 and closes #117.

@tr7zw
Copy link
Owner

tr7zw commented Apr 29, 2024

You are nuts, you also did the 1.20.4 update.
grafik
Also wtf.

About the

Swap to a normal Fabric project layout

, I switched to a new repo that allows building multiple mc versions from the same source ( https://github.com/tr7zw/ProcessedModTemplate can do 1.16.5-1.20.5 fabric/forge/neoforge ) which is nice for when not much changes between versions, which is not the case for Exordium(at least without refactoring it a bunch). Thats why no 1.20.5 branch was available on the old source.

Uhm out of interest, would you be interested in taking over the mod(or pick it up as main dev, making me more of a contributor), as you have now done 2 updates? As I did vent in a few issues like #96 and on Discord, I'm not that happy with the mod, and would gladly pass it on to someone with more care for it. Also ok if you say no, just feels wrong to not have done anything major for the mod with you having done the 2 past updates. (Feel free to contact me on Discord)

@andreasdc
Copy link

Watch out for xz drama here guys 🙏

@tr7zw
Copy link
Owner

tr7zw commented Apr 29, 2024

xz?

@tr7zw tr7zw changed the base branch from 1.20.4 to 1.20.5 April 29, 2024 22:21
@tr7zw tr7zw merged commit bea581a into tr7zw:1.20.5 Apr 29, 2024
1 check passed
@andreasdc
Copy link

What do you think about splitting updates between ticks, as tr7zw suggested some time ago? So that all of the buffer updates and checks don't happen in the same tick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants