匿名解答の追加(openapi) #1280
Merged
匿名解答の追加(openapi) #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
openapiのスキーマ変更に合わせて修正しました |
kaitoyama
requested changes
Dec 1, 2024
| }, | ||
| }, | ||
| { | ||
| description: "update is_anonymous(false->true)", |
There was a problem hiding this comment.
これ、true->falseに対してエラーが発生するっていうtestが欲しいですね
There was a problem hiding this comment.
今の実装だと，controllerの中でリクエストが来た時に匿名→非匿名のチェックをして返していて，modelのUpdateQuestionnaireでは匿名→非匿名のチェックをやっていないと思います(なので，このテストケースはエラーなしで通るはずです)
modelの中にも匿名→非匿名のチェックを入れた方がいいですかね？
There was a problem hiding this comment.
あー、そっかー、であればcontrollerにおいおいテスト追加するとかで対応ですかね。(ほかのビジネスロジックもcontrollerにありそうなので)
|
あとでconflict直します |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1158 をopenapi向けに移植
middlewareが未実装です