icon to userpage #225
Merged
icon to userpage #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
支援課のアイコンは東工大のマークにとりあえずしておきます。公式HPのロゴのページでは余白がなくていい感じにならなかったので公式twitterのプロフィール画像からとっています。それとコンフリクトが怖かったのでissue-174もこっちにまとめてます。 |
nagatea
suggested changes
Oct 22, 2019
Comment on lines
2
to
6
| <v-btn | ||
| dark | ||
| icon | ||
| :to="`/users/${user.name}`" | ||
| > |
| <v-avatar :size="size"> | ||
| <v-img :src="'https://q.trap.jp/api/1.0/public/icon/' + user.name" width="100%" alt=""/> | ||
| <v-img :src="user.name!=='sienka'?'https://q.trap.jp/api/1.0/public/icon/' + user.name:'https://pbs.twimg.com/profile_images/877073041351622657/n31PKuuM.jpg'" width="100%" alt=""/> |
There was a problem hiding this comment.
東工大のアイコンは直リンクじゃなくてこっちで保持しようか
アイコンダウンロードしてclient/public/img/~~.jpgに保存してここから呼ぶようにしてください
client/src/components/UserPage.vue
Outdated
| @@ -8,7 +8,7 @@ | |||
| </div> | |||
| <div> | |||
| <v-avatar size="200"> | |||
| <img :src="`https://q.trap.jp/api/1.0/public/icon/${$route.params.name}`" /> | |||
| <img :src="$route.params.name!=='sienka'?`https://q.trap.jp/api/1.0/public/icon/${$route.params.name}`:'https://pbs.twimg.com/profile_images/877073041351622657/n31PKuuM.jpg'" /> | |||
There was a problem hiding this comment.
支援課かどうかの判定のロジックはcomputedに書いてほしいです(伝わるかな)
nagatea
suggested changes
Oct 24, 2019
client/src/components/UserPage.vue
Outdated
| } | ||
| }, | ||
| watch: { | ||
| '$route' (to, from) { | ||
| this.mount() | ||
| } | ||
| }, | ||
| computed: { | ||
| checkSienka () { | ||
| return this.$route.params.name !== 'sienka' |
There was a problem hiding this comment.
URLまでここで返して大丈夫です
computedに移す目的としては上のになるべくjavascriptの構文を書かないという目的があるので(ほかのとこめっちゃ書いてるけど)
nagatea
suggested changes
Oct 25, 2019
client/src/components/UserPage.vue
Outdated
| } | ||
| }, | ||
| watch: { | ||
| '$route' (to, from) { | ||
| this.mount() | ||
| } | ||
| }, | ||
| computed: { | ||
| navigateImagePath () { | ||
| return this.$route.params.name !== 'sienka' ? `https://q.trap.jp/api/1.0/public/icon/${this.$route.params.name}` : this.sienka |
There was a problem hiding this comment.
sienkaのiconPathが変わることはないからthis.sienkaってせずに'./../img/sienka-icon.jpg'でいいかも
| }, | ||
| computed: { | ||
| navigateImagePath () { | ||
| return this.user.name !== 'sienka' ? `https://q.trap.jp/api/1.0/public/icon/${this.user.name}` : this.sienka |
|
@series2 修正お願いします！ |
nagatea
approved these changes
Nov 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
あっているかわかりませんが、動いたのでこれでいきます