透明な画像を上げると背景が黒くなる問題の修正 #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ryoha000
reviewed
Mar 21, 2023
router/files.go
Outdated
| b := &bytes.Buffer{} | ||
| _ = imaging.Encode(b, imaging.Fit(orig, 360, 480, imaging.Linear), imaging.JPEG, imaging.JPEGQuality(85)) | ||
| _ = imaging.Encode(b, imaging.Fit(newImg, 360, 480, imaging.Linear), imaging.JPEG, imaging.JPEGQuality(85)) |
Comment on lines
+55
to
+56
| draw.Draw(newImg, newImg.Bounds(), &image.Uniform{color.White}, image.Point{}, draw.Src) | ||
| draw.Draw(newImg, newImg.Bounds(), orig, orig.Bounds().Min, draw.Over) |
There was a problem hiding this comment.
draw.DrawMask(newImg, newImg.Bounds(), orig, image.Point{}, &draw.Op{draw.Src}, nil, &draw.SrcOver{})
とかでできそうな気配あるけどどうですか:eyes:(試してない)
There was a problem hiding this comment.
&draw.Op{draw.Src}と&draw.SrcOver{}がうまく行かず
cp-20
added a commit
that referenced
this pull request
Sep 30, 2023
Revert ":arrow_up: GitHub Actionsの依存 (#541)" This reverts commit e98d86b. Revert "Bump Golang from 1.15 to 1.20 (#540)" This reverts commit 60f9ccc. Revert "ポート番号の修正 (#534)" This reverts commit 3e00b30. Revert "透明な画像を上げると背景が黒くなる問題の修正 (#532)" This reverts commit 241a04e. Revert "Add default value (#535)" This reverts commit c56f2b4. Revert "validatorを追加 (#530)" This reverts commit 2b83f22. Revert "enumにした (#529)" This reverts commit 37e9d27. Revert "X-Showcase-User を debug 時無視するように (#531)" This reverts commit 6808496. Revert "GetItemResponseを追加 (#528)" This reverts commit d3e3d7e. Revert "air と dockerize をやめる (#527)" This reverts commit 2059554.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
背景を白色にするようにしました。
&image.Uniform{color.Transparent}で背景を透明にできるようにしようとしたのですが、うまくいかず背景が真っ黒になってしまったため、&image.Uniform{color.White}を使いました。背景が透明なPNGを手元でアップロードしたら、背景が白くなることが確認できました。