Events page #140
Merged
Events page #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehm8128
suggested changes
Dec 5, 2023
|
@Pugma (一応)再レビューしてよさそうなタイミングになったら再レビュー依頼お願いします:pray:(ハッカソン期間なのですぐにできるか微妙ですが) |
mehm8128
suggested changes
Dec 27, 2023
There was a problem hiding this comment.
もうちょっとお願いします:pray:
また、前回のやつ1つ見逃してそうな気するので確認してみてください:eyes:
#140 (comment)
|
これってサーバーの変更が必要な箇所以外もうレビューしてOKな状態だったりするんでしたっけ？ |
|
そうですね、EventLevel以外は修正箇所をすべて反映してあるのでチェックしていただける状況です |
|
OKです、じゃあそこ以外レビューしておきますー |
mehm8128
reviewed
Jan 8, 2024
Comment on lines
10
to
23
| enum All { | ||
| All = 3 | ||
| } | ||
|
|
||
| type EventLevelWithAll = EventLevel | All | ||
|
|
||
| interface Props { | ||
| modelValue: EventLevelWithAll | ||
| } | ||
| const props = defineProps<Props>() | ||
|
|
||
| const emit = defineEmits<{ | ||
| (e: 'update:modelValue', value: EventLevelWithAll): void | ||
| }>() |
There was a problem hiding this comment.
入出力(props, emit)をどっちもeventLevel.tsにあるEventLevelValueにallを追加したunion型で行うようにしてほしいです(tsでenumをそのまま扱うことってあんまりない気がするので)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6