Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vite from 4.4.11 to 5.2.7 #205

Merged
merged 6 commits into from
Apr 20, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 1, 2024

Bumps vite from 4.4.11 to 5.2.7.

Release notes

Sourced from vite's releases.

create-vite@5.2.3

Please refer to CHANGELOG.md for details.

create-vite@5.2.2

Please refer to CHANGELOG.md for details.

create-vite@5.2.1

Please refer to CHANGELOG.md for details.

create-vite@5.2.0

Please refer to CHANGELOG.md for details.

create-vite@5.1.0

Please refer to CHANGELOG.md for details.

create-vite@5.0.0

Please refer to CHANGELOG.md for details.

create-vite@5.0.0-beta.1

Please refer to CHANGELOG.md for details.

create-vite@5.0.0-beta.0

Please refer to CHANGELOG.md for details.

Changelog

Sourced from vite's changelog.

5.2.7 (2024-03-29)

5.2.6 (2024-03-24)

5.2.5 (2024-03-24)

5.2.4 (2024-03-23)

5.2.3 (2024-03-22)

5.2.2 (2024-03-20)

5.2.1 (2024-03-20)

... (truncated)

Commits
  • ad246da release: v5.2.7
  • 45a06da chore: deprecate splitVendorChunkPlugin (#16274)
  • ffedc06 fix(hmr): trigger hmr for missing file import errored module after file creat...
  • dfffea1 fix(hmr): don't mutate module graph when collecting modules (#16302)
  • 1f53796 feat(hmr): reload when HTML file is created/deleted (#16288)
  • 24e376a fix(sourcemap): don't warn even if the sourcesContent is an empty string (#16...
  • 7caef42 fix(deps): update all non-major dependencies (#16258)
  • 890538a fix: skip injecting __vite__mapDeps when it's not used (#16271)
  • 7369016 release: v5.2.6
  • ba5269c fix: fs.deny with globs with directories (#16250)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.4.11 to 5.2.7.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.2.7/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Apr 1, 2024
@Pugma
Copy link
Collaborator

Pugma commented Apr 20, 2024

僕がやった操作を以下にまとめておきます

  • vite-plugin-purge-iconsのアップグレード
    • 元来のv0.9.2はvite v5非対応だったので、これに対応した最新版v0.10.0
  • vite v5で.cjsが非推奨になったために表示されていた警告への対応
    • package.json"type": "module"を追記し、.js .tsを標準でES Module形式と解釈するように
    • postcss.config.jsの形式がCommon JSだったためES Moduleに変更
    • /scriptsディレクトリ内の開発用jsコード / .eslintrc.jsCommon JSだったので.cjsと拡張子を変更
      • これに合わせる形で一部参照ファイルパスの書き換え
      • これはbuild時にバンドルされるファイルじゃないからか、とりあえずはCommon JS形式でも警告は出ませんでした

@ras0q
Copy link
Member

ras0q commented Apr 20, 2024

あとeslintrcだけcjsにしたらCI通りそう?

Copy link
Contributor

@mehm8128 mehm8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動いてるしよさそうです

vite-plugin-purge-iconsのリポジトリ見たら

It's now recommended to use UnoCSS Icons, unplugin-icons or Iconify Icon Components instead of this approach.

って書いてあるから別のにしてもいいかも、リポジトリアーカイブされてるし

一旦approveはするので、issue立てるとかだけでもしておくといいかもです

@Pugma
Copy link
Collaborator

Pugma commented Apr 20, 2024

あ〜〜〜、他のが推奨されているのは見ましたが、リポジトリアーカイブまでは気づきませんでした… (昨日はスマホで見ていたのでPCとUIが違ったと言い訳)
とりあえずissue立てておきます:+1:

@Pugma Pugma merged commit 2356e69 into main Apr 20, 2024
7 checks passed
@Pugma Pugma deleted the dependabot/npm_and_yarn/vite-5.2.7 branch April 20, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants