ボタンコンポーネントの実装 #21
Merged
ボタンコンポーネントの実装 #21
+69
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tesso57
approved these changes
Sep 19, 2022
sapphi-red
reviewed
Sep 19, 2022
src/components/UI/BaseButton.vue
Outdated
| justify-content: center; | ||
| gap: 4px; | ||
| padding: 4px 24px; | ||
| border-radius: 5px; |
There was a problem hiding this comment.
デザインは確認してないのですが、これは意図して4の倍数とか偶数ではない値になってますか？
There was a problem hiding this comment.
Figmaで5pxになっていたのでそのまま使ってしまったのですが、アイコンありだと6pxになっていたので6pxにしようと思います
There was a problem hiding this comment.
もし縦幅が変わることで変化するなら、px指定じゃなくて%指定のが正しそうです
(どっちの意図かはわからないです)
|
↑ みどりさんから approve もらえたので、問題がなければ マージボタン押して大丈夫です！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #17