✨ ToggleSwitchを実装 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehm8128
reviewed
Oct 3, 2022
src/components/UI/ToggleSwitch.vue
Outdated
| <script lang="ts" setup> | ||
| const props = withDefaults( | ||
| defineProps<{ | ||
| modelValue?: boolean |
There was a problem hiding this comment.
optionalにする必要がなさそうかなーと思ったのですが、modelValueを使わない場面って何か想定していますか？
There was a problem hiding this comment.
formの中で使う場面もないので、optionalにする必要ないですね。修正しました:pray:
There was a problem hiding this comment.
これに伴って、modelValueのdefault値も消しておいてほしいです🙏
src/components/UI/ToggleSwitch.vue
Outdated
| <label :class="$style.container"> | ||
| <input | ||
| type="checkbox" | ||
| :checked="props.modelValue" |
There was a problem hiding this comment.
checkedは現在の選択状態じゃなくて初期値を表すらしいので、checkedじゃなくてvalueの方がいい気がします(それとは別にcheckedをpropsで用意してもいいとは思います)(それとも何か別の意図がありますか？)
There was a problem hiding this comment.
v-modelを使うように修正しました:pray:
mehm8128
reviewed
Oct 3, 2022
src/components/UI/ToggleSwitch.vue
Outdated
Comment on lines
46
to
49
| .input:disabled + & { | ||
| pointer-events: none; | ||
| cursor: not-allowed; | ||
| } |
There was a problem hiding this comment.
手元で確認してみた感じ、ここ効いてるかちょっと怪しい感じがしたのでもう一度確認してみていただきたいです
There was a problem hiding this comment.
効いてなかった & pointer-events: none;がいらなさそう？なので、修正しました:pray:
sapphi-red
approved these changes
Oct 4, 2022
tesso57
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
close #18