Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

メンバー入力コンポーネント #33

Merged
merged 12 commits into from
Nov 5, 2022
Merged

Conversation

toshi-pono
Copy link
Member

やったこと

メンバー入力のコンポーネントを作った
memberinput

あとでやること

  • UserIconは一旦自分(toshi00)を読むようにしています

close #25

@toshi-pono toshi-pono self-assigned this Oct 10, 2022
width: 24px;
height: 24px;
background-color: $color-secondary;
mask: url('/icons/account.svg') no-repeat center center;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

アイコンをiconifyから読みたかったけどいい感じにする方法がわからず/icons/account.svgを追加しました。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://icon-sets.iconify.design/mdi/account/
の画像のところにそれっぽいURLがありそうですがどうですか?:eyes:
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここだけ https://api.iconify.design にリクエストが飛ぶ形になってしまうので迷ってます。 他のiconifyのsvgは、プラグインで埋め込まれた状態になってます。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSSでハックする感じだと今の状態が一番よさそうです

<template>
<img
:class="$style.icon"
:src="'https://q.trap.jp/api/v3/public/icon/toshi00'"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とりあえずtoshi00を表示しています

@tesso57 tesso57 mentioned this pull request Oct 10, 2022
@toshi-pono toshi-pono linked an issue Oct 10, 2022 that may be closed by this pull request
Copy link
Contributor

@mehm8128 mehm8128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

今のところ他のところでVueSelect使っていないので大丈夫そうですが、基本機能をまとめたwrapperコンポーネント的なのを作ってもよさそうかなーと思いました

src/components/UI/MemberInput.vue Outdated Show resolved Hide resolved
width: 24px;
height: 24px;
background-color: $color-secondary;
mask: url('/icons/account.svg') no-repeat center center;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://icon-sets.iconify.design/mdi/account/
の画像のところにそれっぽいURLがありそうですがどうですか?:eyes:
image

src/components/UI/MemberInput.vue Outdated Show resolved Hide resolved
src/components/UI/MemberInput.vue Show resolved Hide resolved
src/components/UI/MemberInput.vue Outdated Show resolved Hide resolved
width: 24px;
height: 24px;
background-color: $color-secondary;
mask: url('/icons/account.svg') no-repeat center center;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSSでハックする感じだと今の状態が一番よさそうです

@toshi-pono toshi-pono requested a review from sapphi-red October 17, 2022 12:01
<script lang="ts" setup>
import { computed } from 'vue'
interface Props {
name: string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このname は何を想定していますか ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

traQID (toshi00とか)が入って、userIconを表示するのに使うつもりです。mockだと存在しないIDが返ってくるのでとりあえずtoshi00を表示してます。

あー、あとで直す必要があるのでTODOかissueつけといた方が良いかもですね👀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODOあるとうれしい 🎉
userIdの方が意図がつたわりそう?

Copy link
Contributor

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:yosa: :desu:

@toshi-pono toshi-pono merged commit 5b5504c into main Nov 5, 2022
@toshi-pono toshi-pono deleted the toshi00/member-input branch November 5, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserIcon の実装 MemberInput
4 participants