-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
メンバー入力コンポーネント #33
メンバー入力コンポーネント #33
Conversation
width: 24px; | ||
height: 24px; | ||
background-color: $color-secondary; | ||
mask: url('/icons/account.svg') no-repeat center center; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
アイコンをiconifyから読みたかったけどいい感じにする方法がわからず/icons/account.svg
を追加しました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://icon-sets.iconify.design/mdi/account/
の画像のところにそれっぽいURLがありそうですがどうですか?:eyes:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここだけ https://api.iconify.design にリクエストが飛ぶ形になってしまうので迷ってます。 他のiconifyのsvgは、プラグインで埋め込まれた状態になってます。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSSでハックする感じだと今の状態が一番よさそうです
src/components/UI/UserIcon.vue
Outdated
<template> | ||
<img | ||
:class="$style.icon" | ||
:src="'https://q.trap.jp/api/v3/public/icon/toshi00'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
とりあえずtoshi00を表示しています
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
今のところ他のところでVueSelect使っていないので大丈夫そうですが、基本機能をまとめたwrapperコンポーネント的なのを作ってもよさそうかなーと思いました
width: 24px; | ||
height: 24px; | ||
background-color: $color-secondary; | ||
mask: url('/icons/account.svg') no-repeat center center; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://icon-sets.iconify.design/mdi/account/
の画像のところにそれっぽいURLがありそうですがどうですか?:eyes:
width: 24px; | ||
height: 24px; | ||
background-color: $color-secondary; | ||
mask: url('/icons/account.svg') no-repeat center center; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSSでハックする感じだと今の状態が一番よさそうです
src/components/UI/UserIcon.vue
Outdated
<script lang="ts" setup> | ||
import { computed } from 'vue' | ||
interface Props { | ||
name: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
このname
は何を想定していますか ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
traQID (toshi00とか)が入って、userIconを表示するのに使うつもりです。mockだと存在しないIDが返ってくるのでとりあえずtoshi00を表示してます。
あー、あとで直す必要があるのでTODOかissueつけといた方が良いかもですね👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODOあるとうれしい 🎉
userId
の方が意図がつたわりそう?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:yosa: :desu:
やったこと
メンバー入力のコンポーネントを作った
あとでやること
close #25