Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/user/accounts の実装 #40

Merged
merged 10 commits into from
Oct 24, 2022
Merged

/user/accounts の実装 #40

merged 10 commits into from
Oct 24, 2022

Conversation

mehm8128
Copy link
Contributor

@mehm8128 mehm8128 commented Oct 12, 2022

close #34

相談したいこと:AtCoderのロゴだけIconifyにありませんでした:eyes_komatta:
また、QiitaがあるのでZennも追加しておいた方が良さそうで追加したのですが、サーバーも修正する必要がありそうです(あとCTF班のサイトだけないので、ポートフォリオに載せられそうなサイトがあれば追加したいかも?)

@mehm8128 mehm8128 marked this pull request as ready for review October 12, 2022 08:05
@tesso57
Copy link
Member

tesso57 commented Oct 12, 2022

外部向けのページを実装するときにも、AtCoder のアイコンがなくて困った記憶があります。
traPtitech/traPortfolio-UI#38
AtCoder のロゴは、許可制っぽいらしいので、前回は適当なSVGを置いてしのぎました。サーバー側の人たちと相談した方がよさそう。
CTF班向けのURLはかなりありですね~
どのみちどっちも、traQで話した方がよさそうっすね。

@tesso57
Copy link
Member

tesso57 commented Oct 12, 2022

traQの方に相談投げました。:man_bowing:

Copy link
Member

@tesso57 tesso57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

お願いします 🙏

src/components/Layout/PageContainer.vue Show resolved Hide resolved
src/pages/UserAccounts.vue Outdated Show resolved Hide resolved
src/components/UserAccounts/AccountItem.vue Outdated Show resolved Hide resolved
src/components/UserAccounts/ServiceLogo.vue Outdated Show resolved Hide resolved
src/components/UserAccounts/AccountItem.vue Outdated Show resolved Hide resolved
src/components/UserAccounts/AccountItem.vue Outdated Show resolved Hide resolved
src/components/UserAccounts/ServiceLogo.vue Outdated Show resolved Hide resolved
src/pages/UserAccounts.vue Outdated Show resolved Hide resolved
src/consts/services.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

デザインの細かいとこ(画面動かして壊れないかとか)はチェックしてないんですが、コードはよさそうです 👍 🎊

Copy link
Member

@tesso57 tesso57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさです

@mehm8128 mehm8128 merged commit cdfaa3c into main Oct 24, 2022
@mehm8128 mehm8128 deleted the feat/userAccountsPage branch October 24, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/user/accounts
3 participants