検索フォームの実装 #43
Merged
検索フォームの実装 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://icon-sets.iconify.design/mdi/at/ @のアイコンがあるので、 |
なるほど、よさそうです！ |
|
そうですね。今あるやつはなくして、FormInputを改修する感じですね。 |
mehm8128
requested review from
sapphi-red,
toshi-pono and
tesso57
and removed request for
sapphi-red
tesso57
reviewed
Oct 26, 2022
src/components/UI/FormInput.vue
Outdated
| @@ -40,7 +40,9 @@ const handleInput = (event: Event) => { | |||
|
|
|||
| <template> | |||
| <div :class="$style.container" :data-has-anchor="props.hasAnchor"> | |||
| <span v-if="props.hasAtmark" :class="$style.atmark"> @ </span> | |||
| <div v-if="props.icon !== undefined" :class="$style.iconContainer"> | |||
There was a problem hiding this comment.
めっちゃ細かいんですが、typeof icon !== 'undefined' の方がいいかもしれません。
参考: https://developer.mozilla.org/ja/docs/Web/JavaScript/Reference/Global_Objects/undefined
There was a problem hiding this comment.
strict modeではundefinedを上書きできないので元のままでも大丈夫ですね 🖖 ESMは常にstrict mode)
下を実行するとエラーになります
function f () {
"use strict";
undefined = 'po';
}
f();
tesso57
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inputformと似たような感じになっちゃいましたけど大丈夫ですかねこれ