Fix/navigationbar #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehm8128
reviewed
Nov 3, 2022
Comment on lines
+23
to
+28
| .icon { | ||
| cursor: pointer; | ||
| color: $color-secondary; | ||
| &:hover { | ||
| opacity: 0.8; | ||
| } |
There was a problem hiding this comment.
iconってなんかdisplay: flex;つけないと下にちょっと余白できちゃって高さが微妙な感じになるので毎回つけてるんですけど、Iconコンポーネント自体をいじった方がいいんですかね🤔
|
|
||
| const isActive = computed(() => { | ||
| if (props.path === '/') return currentRoute.path === props.path | ||
| return currentRoute.path.startsWith(`${props.path}`) |
There was a problem hiding this comment.
ここ前に気になってたので実装してもらえて:tasukaru::gozaimasu:
mehm8128
reviewed
Nov 6, 2022
mehm8128
approved these changes
Nov 7, 2022
toshi-pono
reviewed
Nov 7, 2022
| import NavigationLinksItem from './NavigationLinksItem.vue' | ||
| import { routes } from '/@/use/routeInfo' | ||
| </script> | ||
|
|
||
| <template> | ||
| <ul> |
There was a problem hiding this comment.
ulの子要素は0個以上のli、script、templateらしいです。
今、navigation-links-itemがaタグで、直下にaタグが来てるのでliタグが来るように修正したほうがいいかも？です。
There was a problem hiding this comment.
aタグは透過的コンテンツなのでul>a>liの構造でもul>liとみなせて問題ないはずです (もちろん逆でも問題はない)
https://developer.mozilla.org/ja/docs/Web/HTML/Element/a
sapphi-red
reviewed
Nov 8, 2022
| import NavigationLinksItem from './NavigationLinksItem.vue' | ||
| import { routes } from '/@/use/routeInfo' | ||
| </script> | ||
|
|
||
| <template> | ||
| <ul> |
There was a problem hiding this comment.
aタグは透過的コンテンツなのでul>a>liの構造でもul>liとみなせて問題ないはずです (もちろん逆でも問題はない)
https://developer.mozilla.org/ja/docs/Web/HTML/Element/a
sapphi-red
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.