プロフィールページの実装 #48
Merged
プロフィールページの実装 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
まだ実装されてなかったんですが、本名の公開が許可されてない場合はRealNameが空になる予定ですね Checkも必要であれば返してもいいと思います |
|
あ、:haakusimasita: |
|
checkがわかりにくいのはそうなので別の名前で追加するようにしますかね
|
tesso57
reviewed
Nov 15, 2022
Comment on lines
+20
to
+21
| <p :class="$style.name">{{ user.name }}</p> | ||
| <p :class="$style.realName">{{ user.realName }}</p> |
There was a problem hiding this comment.
これどんな感じになってるかスクショもらえたりしますか？
折り返すようにしたので手元だと複数行になってくれるのですが🤔(複数行にするのではなくて別のデザインも検討してみる、という意味なのであれば:haakusimasita:)
sapphi-red
reviewed
Nov 22, 2022
sapphi-red
reviewed
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2
本名を公開するかどうかのフラグがサーバーから渡されてない気がするので要確認追加してもらうことになった