日付コンポーネントの実装 #56
Merged
日付コンポーネントの実装 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tesso57
reviewed
Mar 8, 2023
src/components/UI/FormDate.vue
Outdated
|
|
||
| <template> | ||
| <div :class="$style.container"> | ||
| <icon name="mdi:calendar-clock" :class="$style.icon" /> |
There was a problem hiding this comment.
カレンダーっぽいアイコンが２つ並んでて微妙だと思ったので、消すことにします。
Comment on lines
+21
to
+26
| <input | ||
| :class="$style.input" | ||
| :data-is-blank="props.modelValue === ''" | ||
| type="datetime-local" | ||
| :value="props.modelValue" | ||
| @input="handleInput" |
There was a problem hiding this comment.
いい感じにデフォルトのアイコンもfocusしたときに色変わったらいいなって思ってます。
src/components/UI/FormDate.vue
Outdated
| .container { | ||
| display: flex; | ||
| align-items: center; | ||
| padding: 8px; |
|
|
tesso57
approved these changes
Mar 22, 2023
src/pages/Index.vue
Outdated
Comment on lines
1
to
14
| <script lang="ts" setup> | ||
| import ContentHeader from '/@/components/Layout/ContentHeader.vue' | ||
| import PageInfoPanels from '/@/components/Index/PageInfoPanels.vue' | ||
| import PageContainer from '/@/components/Layout/PageContainer.vue' | ||
| import FormDuration from '/@/components/UI/FormDuration.vue' | ||
| import { ref } from 'vue' | ||
| import { Duration } from '/@/lib/apis' | ||
|
|
||
| const value = ref<Duration>({ since: '', until: '' }) | ||
| </script> | ||
|
|
||
| <template> | ||
| <page-container> | ||
| <content-header | ||
| icon-name="mdi:apps" | ||
| :header-texts="[{ title: 'Top', url: '/' }]" | ||
| detail="ポートフォリオの設定を変更します" | ||
| :class="$style.header" | ||
| /> | ||
| <page-info-panels /> | ||
| <form-duration v-model="value" /> | ||
| </page-container> | ||
| </template> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #55
sinceとuntilがセットで使われていることが多そうなので、単体コンポーネントを2つ使ってセットのも作りました
必須アイコンはsinceのみ必須の場合は「～から」の横に、sinceもuntilも必須の場合は「日時」の横につけていそうなので、sinceのみの場合だけ対応しました(untilのみの場合は存在しないはず)
formDurationは以下のような感じで動くと思います(formDateはstring型の変数でv-model使うだけです)