-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AtCoderのロゴ表示に対応 #194
AtCoderのロゴ表示に対応 #194
Conversation
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨Latest suggestions up to c155c46
Previous suggestionsSuggestions up to commit 1e4253f
|
/improve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consts/services.ts
の
icon: 'atcoder' //アイコンは保留
のコメントを消しておいてほしいです🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:tasukatta::kansya_kansya:
User description
#153 への部分的対応
AtCoderロゴのsvgがなかったためpngで対応
PR Type
enhancement, documentation
Description
AIcon.vue
に追加AtCoder.png
をインポートし、条件に応じて表示shims-png.d.ts
に追加Changes walkthrough 📝
AIcon.vue
AtCoderロゴ表示のための条件分岐と画像追加
src/components/UI/AIcon.vue
AtCoder.png
をインポートv-if
を使用してimg
タグを条件付きでレンダリングshims-png.d.ts
PNGファイルの型定義追加
src/types/shims-png.d.ts