Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user の description を複数行に対応させた #196

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

Kaki256
Copy link
Contributor

@Kaki256 Kaki256 commented Jul 8, 2024

PR Type

Enhancement


Description

  • BioContainer.vue のスタイルに white-space: pre-wrap を追加し、ユーザーの説明が複数行に対応できるように修正。

Changes walkthrough 📝

Relevant files
Enhancement
BioContainer.vue
スタイルに `white-space: pre-wrap` を追加                                               

src/components/User/BioContainer.vue

  • white-space: pre-wrap を追加
  • スタイルの修正
+1/-0     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

Copy link

github-actions bot commented Jul 8, 2024

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review

Copy link

github-actions bot commented Jul 8, 2024

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Enhancement
テキストの折り返しを改善し、長い単語がコンテナからはみ出るのを防ぎます。

white-space: pre-wrap;
を使用すると、テキストがコンテナの幅を超えると自動的に折り返されますが、意図しない改行が入る可能性があります。ユーザーが入力した改行を尊重しつつ、長い単語やURLが折り返し無しで表示される問題を防ぐために、word-break:
break-word; を追加することを提案します。

src/components/User/BioContainer.vue [15]

 white-space: pre-wrap;
+word-break: break-word;
 
Suggestion importance[1-10]: 9

Why: The suggestion to add word-break: break-word; alongside white-space: pre-wrap; is valid and improves text wrapping behavior by preventing long words or URLs from overflowing the container. This is a significant enhancement for better text display and user experience.

9

Copy link
Collaborator

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改行の反映自体はできてるんですが、ここだけ確認をお願いします!
MDNのリンクも貼ってあるので見てみてください

src/components/User/BioContainer.vue Show resolved Hide resolved
@Pugma
Copy link
Collaborator

Pugma commented Jul 8, 2024

@ogu-kazemiya レビューをするおぐくんは、このCSSがどんな意味のものなのかをぴなくん同様にMDNで確認してみてほしいです
改行処理が正常にできているかを確認し、自分で納得が行ったタイミングでapproveを出してもらえればと思います

Copy link
Collaborator

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正もやってくれてありがとうございます
マージしちゃってください!

@Kaki256 Kaki256 merged commit ae900bc into master Jul 9, 2024
8 checks passed
@Kaki256 Kaki256 deleted the fix/user-description-multiline branch July 9, 2024 07:47
@Pugma Pugma linked an issue Jul 9, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

userのdescriptionを複数行に対応させる
3 participants