-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/scss #236
Conversation
Preview (prod) → https://236-prod.portfolio-preview.trapti.tech/ |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vue/max-attributes-per-lineを別で設定しないといけないのはよくわかんない(flat/recommendedに含まれてるって書いてある)けど、別で書かないと動いてなさそうなのでこれで良さそう。
https://eslint.vuejs.org/rules/max-attributes-per-line
User description
これで CI 系の warning は改善終了
PR Type
enhancement, configuration changes
Description
api: 'modern-compiler'
を使用するように変更しました。@import
から@use
に変更しました。vue/max-attributes-per-line
ルールを追加し、1行あたりの属性数を制限しました。Changes walkthrough 📝
vite.config.ts
Update SCSS preprocessor options and import method
vite.config.ts
api: 'modern-compiler'
.@import
to@use
.eslint.config.js
Add ESLint rule for max attributes per line
eslint.config.js
vue/max-attributes-per-line
rule to ESLint configuration.