💥 change YearWithSemesterDuration.Until type to optional #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
==========================================
+ Coverage 33.19% 33.39% +0.19%
==========================================
Files 54 54
Lines 4329 4345 +16
==========================================
+ Hits 1437 1451 +14
- Misses 2863 2864 +1
- Partials 29 30 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
H1rono
reviewed
Jun 23, 2024
Comment on lines
-174
to
+175
| UntilYear: duration.Until.Year, | ||
| UntilSemester: duration.Until.Semester, | ||
| UntilYear: duration.Until.ValueOrZero().Year, | ||
| UntilSemester: duration.Until.ValueOrZero().Semester, |
There was a problem hiding this comment.
ここだけみるとめちゃくちゃ不味そうに見える
projectmemberが0年0期まで存在したってなんだ？？？と
There was a problem hiding this comment.
正直コンパイルエラー消してテスト通すために適当に対処したところはある🙇
一応これの逆操作はuntilがvalid=falseになるので再度modelから取り出してdomainに詰めた時は無期限として扱われる
There was a problem hiding this comment.
mustAddなんとかみたいな関数は今出してるテスト改正PRの派生で消えるのでその時に何とかします
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.