Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: projectの中間テーブルの改善 #689

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

Tennessine699
Copy link
Contributor

resolves #688
project_members_belongingsからproject_member_idを消去し、project_idとuser_idをprimary_keyにしました

@Tennessine699 Tennessine699 requested a review from ras0q June 28, 2024 15:51
@ras0q ras0q changed the title projectの中間テーブルの改善 breaking: projectの中間テーブルの改善 Jun 28, 2024
Copy link
Member

@ras0q ras0q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.83%. Comparing base (2280032) to head (212d6e8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
- Coverage   73.21%   72.83%   -0.38%     
==========================================
  Files          54       54              
  Lines        4267     4256      -11     
==========================================
- Hits         3124     3100      -24     
- Misses        994     1011      +17     
+ Partials      149      145       -4     
Flag Coverage Δ
integration 72.83% <ø> (-0.38%) ⬇️
unit 72.83% <ø> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tennessine699 Tennessine699 merged commit d225f3e into main Jun 28, 2024
11 checks passed
@Tennessine699 Tennessine699 deleted the improve/delete_project_member_id branch June 28, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

中間テーブルのprimary keyを複合primary keyにする
2 participants