Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

パッケージ構成の変更 #705

Merged
merged 3 commits into from
Jul 21, 2024
Merged

パッケージ構成の変更 #705

merged 3 commits into from
Jul 21, 2024

Conversation

ras0q
Copy link
Member

@ras0q ras0q commented Jul 20, 2024

プロジェクト内の一連の処理をinternalパッケージ以下にまとめた
util->pkgs,interfaces/handler->handlerなどの変更も入れている
util(pkgs)はinternalの外に出してもいいがtraPortfolio以外のパッケージから使われることもないのでinternal以下に置いた

@ras0q ras0q requested a review from H1rono July 20, 2024 07:19
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.46%. Comparing base (b0977ea) to head (d5e27ce).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
+ Coverage   73.49%   74.46%   +0.97%     
==========================================
  Files          54       52       -2     
  Lines        4218     4163      -55     
==========================================
  Hits         3100     3100              
+ Misses        965      910      -55     
  Partials      153      153              
Flag Coverage Δ
integration 74.46% <ø> (+0.97%) ⬆️
unit 74.46% <ø> (+0.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうなんですが、integration_testsだけinternalの外にあるのはどうしてですか?これも動かしちゃっていい気がしますが

@ras0q
Copy link
Member Author

ras0q commented Jul 21, 2024

分けてるのをよく見るくらいの理由しか出せないな、、

https://github.com/moby/moby
https://github.com/googleapis/google-api-go-client

@ras0q
Copy link
Member Author

ras0q commented Jul 21, 2024

利点としてはgo test ./internalとgo test ./integration_testsでテストの実行を分けられるとかがある (internalの中に入れると変更前のようにgo listをごにょごにょする必要がある)

@ras0q
Copy link
Member Author

ras0q commented Jul 21, 2024

とりあえずマージ

@ras0q ras0q merged commit 1445f22 into main Jul 21, 2024
11 checks passed
@ras0q ras0q deleted the refactor/internal branch July 21, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants