Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 remove Makefile (optionally migrate to xc) #710

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Conversation

ras0q
Copy link
Member

@ras0q ras0q commented Jul 21, 2024

No description provided.

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.29%. Comparing base (4e70c41) to head (cc1eaef).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
- Coverage   74.39%   74.29%   -0.10%     
==========================================
  Files          52       52              
  Lines        4163     4163              
==========================================
- Hits         3097     3093       -4     
- Misses        912      923      +11     
+ Partials      154      147       -7     
Flag Coverage Δ
integration 74.29% <ø> (-0.10%) ⬇️
unit 74.29% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ras0q ras0q force-pushed the refactor/makefile-bye branch from fe13420 to 52027f0 Compare July 21, 2024 15:16
@ras0q ras0q force-pushed the refactor/makefile-bye branch from dad1194 to d6e575f Compare July 21, 2024 15:41
@ras0q ras0q requested a review from H1rono July 21, 2024 15:48
Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

気になったこと書いた
devcontainerでxc用意されてると嬉しいですね

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@ras0q
Copy link
Member Author

ras0q commented Jul 21, 2024

変な時間にリクエストしたのにありがとうございます
コメント返しました

@ras0q
Copy link
Member Author

ras0q commented Jul 21, 2024

devcontainerはあんま整備されてなかったので今度まとめてやります

Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

まあ、いいんじゃないでしょうか

@ras0q ras0q merged commit 22c439e into main Jul 22, 2024
11 checks passed
@ras0q ras0q deleted the refactor/makefile-bye branch July 22, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants