use deep copy to avoid

circular pointer reference
traPtitech · Dec 11, 2023 · 53cc3d9 · 53cc3d9
1 parent fa38f02
commit 53cc3d9
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/service/imaging/processor_default.go b/service/imaging/processor_default.go
@@ -174,7 +174,11 @@ func (p *defaultProcessor) FitAnimationGIF(src io.Reader, width, height int) (*b
 
 		// Disposalが1に設定されていたら、Disposeされていないフレームを更新
 		if srcImage.Disposal[i] == gif.DisposalNone {
-			unDisposedFrame = tempCanvas
+			unDisposedFrame = &image.NRGBA{
+				Pix:    append([]uint8{}, tempCanvas.Pix...),
+				Stride: tempCanvas.Stride,
+				Rect:   tempCanvas.Rect,
+			} // tempCanvasはポインタを使い回しているので、Deep Copyする
 		}
 
 		// 拡縮用GoRoutineを起動