Imagemagickを抹殺 #2143
Merged
Imagemagickを抹殺 #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logica0419
force-pushed
the
eliminate-imagemagick
branch
from
c3873b0 to
4b6339b
Compare
motoki317
reviewed
Dec 9, 2023
そんなに掛かるんだ... PRの検証を見たところ、imagemagickとそう大差は無いようですが、気に留めておきたいかもですね |
Co-authored-by: motoki317 <motoki317@gmail.com>
フレーム数だけリサイズをしなければいけないので、それだけかかるのは仕方なそうな感じがあります |
Co-authored-by: motoki317 <motoki317@gmail.com>
pikachu0310
previously approved these changes
Dec 9, 2023
|
メモリ使用量はチェックしておくと良さそうです |
|
時間
Imagemagick1.85 秒 Pure Go2.13 秒 わずかに遅くなっている CPU / メモリ使用量測定 (top)
ImagemagickPure Go最大CPU使用率が1/3程度になっているため、並列化による高速化は可能そう メモリ使用量測定 (pprof)main.goを以下に書き換えプロファイリング package main
import (
"image"
"log"
"os"
"time"
"github.com/pkg/profile"
"github.com/traPtitech/traQ/service/imaging"
)
func main() {
defer profile.Start(profile.MemProfile, profile.ProfilePath(".")).Stop()
t := time.Now()
f, _ := os.Open("cube.gif")
_, _ = imaging.NewProcessor(imaging.Config{
MaxPixels: 2560 * 1600,
Concurrency: 1,
ThumbnailMaxSize: image.Pt(360, 480),
ImageMagickPath: {Imagemagickのパス (Pure Goの時は設定していない)},
}).FitAnimationGIF(f, 256, 256)
log.Printf("done: %v", time.Since(t))
}ImagemagickPure Go |
motoki317
reviewed
Dec 10, 2023
This reverts commit 2185fc8.
motoki317
reviewed
Dec 11, 2023
circular pointer reference
motoki317
previously approved these changes
Dec 11, 2023
utils/utils.go
Outdated
| func Map[T, R any](s []T, mapper func(item T) R) []R { | ||
| ret := make([]R, len(s)) | ||
| for i := range s { | ||
| ret[i] = mapper(s[i]) | ||
| } | ||
| return ret | ||
| } | ||
|
|
||
| func IoReaderToBytes(r io.Reader) ([]byte, error) { |
There was a problem hiding this comment.
ReadAllって使って良かったっけってなっちゃったけど、よく考えたらそれioutilの話か…ってなりました
書き換えます
utils/utils.go
Outdated
| return buf.Bytes(), nil | ||
| } | ||
|
|
||
| func MustIoReaderToBytes(r io.Reader) []byte { |
これやると #1875 とかもやりやすくなるのかなって少し思いました |
|
それはアップロード処理とは関係無いような |
|
なるほど、何も見ずとりあえず言ってみただけなので多分そっちが正しい |
This was referenced Dec 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
背景
実装