Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adminでなくても自分のスタンプを削除できるように #2474

Merged
merged 9 commits into from
Jul 22, 2024

Conversation

24take
Copy link
Contributor

@24take 24take commented Jul 2, 2024

close #2471
一般ユーザーとwrite権限を持つoauthクライアントが自身の持つスタンプを削除できるように変更しました。

@24take 24take requested a review from pikachu0310 July 2, 2024 08:10
@24take 24take marked this pull request as draft July 2, 2024 08:18
@24take 24take marked this pull request as ready for review July 2, 2024 08:41
@kaitoyama kaitoyama self-requested a review July 10, 2024 10:10
Copy link
Contributor

@kaitoyama kaitoyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

具体の実装はLGTMです!
(他のPRでv36使ってるのあるので、マージタイミングでconflictしてないかだけ注意してください!)

migration/v36.go Outdated
"gorm.io/gorm"
)

// v16 パーミッション修正
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多分コピペ元のままなので、内容に合わせて修正お願いします

@24take 24take requested a review from kaitoyama July 22, 2024 07:37
Copy link
Contributor

@kaitoyama kaitoyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!
TY!

@pikachu0310 pikachu0310 merged commit aede76d into master Jul 22, 2024
6 checks passed
@pikachu0310 pikachu0310 deleted the issue2471 branch July 22, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adminでなくてもスタンプ削除をできるようにする
3 participants