Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ stagingブランチを設定する事でstaging環境でデプロイされるように #2488

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

✨ stagingブランチを設定する事でstaging環境でデプロイされるように #2488

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f44977
:sparkles: stagingブランチを設定する事でstaging環境でデプロイされるように
pikachu0310 Jul 24, 2024
0ece60a
:art: master.ymlに統一
pikachu0310 Jul 24, 2024
d019c8a
:sparkles: manual dispatch でコミット/ブランチを指定して手動でstaging環境を立ち上げれるように変更
pikachu0310 Jul 24, 2024
d23a6c0
:art: ブランチ名のみ指定可能に変更、イメージタグなどを適切な名前に自動で変更するように
pikachu0310 Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,15 @@ on:
push:
branches:
- master
workflow_dispatch:
inputs:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ブランチ指定で動かすのは特に設定なしでできます

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/traPtitech/traQ/blob/master/.github/workflows/renovate.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflow_dispatch:
だけでも良さそうですが、説明とデフォルト付けた方が良いかなと思うので残しておこうと思ってます。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

流石にデフォルトはレポジトリのデフォルトブランチになるんじゃ

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これたぶんpikachuが思ってる挙動と違って、このデフォルトであるドロップダウンの下にinputがもう一つ生えてそこにブランチ入力することになります

ドロップダウンのデフォルトはレポジトリのデフォルトブランチです

image

ここのDry-runにブランチ名を入力することになる

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほど、なら workflow_dispatch: だけで良さそうですね。ありがとうございます。

branch:
description: 'Branch to deploy'
required: true
default: 'master'
commit:
description: 'Specific commit to deploy'
required: false
motoki317 marked this conversation as resolved.
Show resolved Hide resolved

env:
IMAGE_NAME: traq
Expand All @@ -15,9 +24,15 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.inputs.branch || github.ref }}
- name: Set TRAQ_VERSION env
run: echo "TRAQ_VERSION=master-SNAPSHOT" >> $GITHUB_ENV
- name: Set TRAQ_REVISION env
if: ${{ github.event.inputs.commit != '' }}
run: echo "TRAQ_REVISION=${{ github.event.inputs.commit }}" >> $GITHUB_ENV
- name: Set TRAQ_REVISION env (fallback)
if: ${{ github.event.inputs.commit == '' }}
run: echo "TRAQ_REVISION=$(git rev-parse --short HEAD)" >> $GITHUB_ENV
- name: Set up QEMU
uses: docker/setup-qemu-action@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

（下の方）イメージタグは"master"固定で大丈夫ですか？
（わかりやすさ的に）

Expand Down
Loading