Twitterを𝕏で置き換え #4102
Merged
Twitterを𝕏で置き換え #4102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod) → https://4102-prod.traq-preview.trapti.tech/ |
ras0q
reviewed
Oct 18, 2023
Comment on lines
36
to
37
| <p v-if="twitterId !== ''" :class="$style.p"> | ||
| <p v-if="xId !== ''" :class="$style.p"> | ||
| <circle-icon |
There was a problem hiding this comment.
他もそうだけど再度サービス名が変わる or XよりメジャーなSNSが出てきてSNSを変えたくなるみたいな場合にxIdだと変更が辛そうだなって思うので個人的にはtwitterXIdくらいで留めておくのでいい気がします
There was a problem hiding this comment.
確かに
なんならサーバー依存してるところはまだtwitterのままなので、見た目に影響ないところはtwitterのままでもいいかもですね
There was a problem hiding this comment.
今のところ置換で他の混ざっちゃうこととかなさそうなのでこのままでもいい気がしてたのですが、サーバーに依存してる部分と依存してない部分で違うのも確かに微妙なので、一旦見た目に影響ないところは戻しますね
twitterXIdはちょっと微妙な気がします(置き換えるなら置き換えちゃいたいし、twitterXにするくらいならtwitterのままでいい気がします)
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
mehm8128
force-pushed
the
fix/replace_twitter_with_x
branch
from
393cfd8
to
e52f614
Compare
|
ですね、もう一人待ちます |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4094