Modalの分岐にObjectを使うようにした #4325
Merged
Modalの分岐にObjectを使うようにした #4325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod) → https://4325-prod.traq-preview.trapti.tech/ |
|
@ZOI-dayo CI落ちてるのでちょっとチェックしますね |
cp-20
reviewed
Jul 7, 2024
| return GroupMemberAddModal | ||
| case 'settings-theme-edit': | ||
| return SettingsThemeEditModal | ||
| if (currentState.value && currentState.value.type in components) { |
There was a problem hiding this comment.
should: in 演算子は結構怪しくて、これをちゃんと書くなら Object.hasOwn(components, currentState.value.type) と書くのが良い気がします
↑の例だと'toString' in {} は true です
There was a problem hiding this comment.
imo: そもそも型安全性が確保されているのでわざわざチェックする必要はないような気もします
Pugma
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4189